Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: confirm task tests #669

Merged
merged 5 commits into from
May 15, 2023

Conversation

derrabauke
Copy link
Contributor

@derrabauke derrabauke commented May 15, 2023

Base on #670

@derrabauke derrabauke self-assigned this May 15, 2023
@derrabauke derrabauke added bug Something isn't working dependencies Pull requests that update a dependency file labels May 15, 2023
@derrabauke derrabauke force-pushed the fix-tests-confirm-task branch 2 times, most recently from 9a5273f to 70ed030 Compare May 15, 2023 14:56
@derrabauke derrabauke marked this pull request as ready for review May 15, 2023 15:44
@derrabauke derrabauke requested a review from czosel May 15, 2023 15:44
@derrabauke derrabauke merged commit 01db8a2 into projectcaluma:main May 15, 2023
@derrabauke derrabauke deleted the fix-tests-confirm-task branch May 15, 2023 16:42
derrabauke pushed a commit that referenced this pull request May 16, 2023
# [7.0.0](v6.3.2...v7.0.0) (2023-05-16)

### Bug Fixes

* confirm task tests ([#669](#669)) ([01db8a2](01db8a2))
* **scopes:** show updated parent after selection ([#665](#665)) ([2eb3440](2eb3440))

### chore

* adapt ember try scenarios ([#670](#670)) ([f9e530b](f9e530b))

### BREAKING CHANGES

* drop support for ember v3.24

* chore(deps): update ember-ty to v3.0.0-beta.1

Prevents local build error.

* test(confirm-task): revert waitUntil calls

* fix(confirm-task): catch nested promise rejection

* test(confirm-task): skip flaky test
* drop support for ember v3.24

* chore(deps): update ember-ty to v3.0.0-beta.1

Prevents local build error.
@derrabauke
Copy link
Contributor Author

🎉 This PR is included in version 7.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants